Update fixtures to pass PHPUnit#559
Merged
oscarotero merged 3 commits intophp-embed:masterfrom Oct 5, 2025
Merged
Conversation
Collaborator
|
thank you. Can you update the actions used in the workflow? The test is failing because it's using a very old version. |
Contributor
Author
|
Okey, I'll fix it. |
Contributor
Author
|
I did it. |
Collaborator
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hi, I updated the fixtures for PHPUnit. All tests (except Instagram and fb) are pass.
In DocumentTest::testSelectors is watch the Wired article, but the URL currently redirect to the top page. So, this may mean the test case isn’t good.
(I’m planning to open a aanother PR(fix issue with PHPStan), and first wanted to get the tests green.)
tests result.
tiny update in
Document::__constructhttps://github.com/uzulla/PHpEmbed-Embed/pull/2/checks?sha=5712cf371df403f981af3bd2687b2652cef7b278
because PHP version differences.
ref: #552
Deps detail.
Details